[PATCH] D71365: expand printf when compiling HIP to AMDGPU

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 6 07:52:50 PST 2020


arsenm added inline comments.


================
Comment at: clang/test/CodeGenHIP/printf.cpp:18
+}
+
+// CHECK: [[BEGIN:%.*]]   = call i64 @__ockl_printf_begin(i64 0)
----------------
This could use a lot more testcases. Can you add some half, float, and double as well as pointers (including different address spaces) and vectors?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71365/new/

https://reviews.llvm.org/D71365





More information about the llvm-commits mailing list