[PATCH] D71743: [ARM][MVE] Enable masked gathers from vector of pointers

[Anna Welker via Phabricator via llvm-commits]

anwel marked 7 inline comments as done.
anwel added inline comments.


================
Comment at: llvm/lib/Target/ARM/MVEGatherScatterLowering.cpp:1
+//===- ARMGatherScatterLowering.cpp - Gather/Scatter lowering ------------===//
+//
----------------
dmgreen wrote:
> This looks a touch too short, unless my eyes deceive me.
Yes, you're right


================
Comment at: llvm/lib/Target/ARM/MVEGatherScatterLowering.cpp:15
+
+#include <algorithm>
+#include <cassert>
----------------
dmgreen wrote:
> It's customary in llvm to put std headers below the llvm headers.
Okay in that case I'll of course follow the standard format


================
Comment at: llvm/lib/Target/ARM/MVEGatherScatterLowering.cpp:86
+
+bool isLegalAlignment(unsigned NumElements, unsigned ElemSize,
+                      unsigned Alignment) {
----------------
dmgreen wrote:
> Any function that is only used in this file can be static.
Do you mean private?


================
Comment at: llvm/lib/Target/ARM/MVEGatherScatterLowering.cpp:178
+
+  bool ModifiedDT;
+  for (IntrinsicInst *I : Gathers)
----------------
dmgreen wrote:
> This isn't used it seems.
No, sorry. I'll remove it.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71743/new/

https://reviews.llvm.org/D71743