[PATCH] D71743: [TTI][ARM][MVE] Enable masked gathers from vector of pointers

[Anna Welker via Phabricator via llvm-commits]

anwel marked 6 inline comments as done.
anwel added inline comments.


================
Comment at: llvm/include/llvm/Analysis/TargetTransformInfo.h:611
+  /// still IR. Return true if legalised.
+  bool customLegalizeMaskedGather(IntrinsicInst *I, bool &ModifiedDT) const;
+
----------------
dmgreen wrote:
> RKSimon wrote:
> > Its unusual to put transformational methods inside TargetTransformInfo - that tends to be legality/cost checks, not IR transforms.
> Oh yeah. We were thinking of the interleaved load lowering that we do, but now that I look again that happens in TLI. I had not realized.
> 
> Because of the amount of code this might turn into (and how long TLI is already), it might be better as a separate pass though.
> 
> We will look into this after the hols. Thanks for the comments.
You are right, putting the transforming code into a pass looks a lot cleaner and should also make future additions easier and more localized. I'll update the diff with a new version.


================
Comment at: llvm/lib/Target/ARM/ARMTargetTransformInfo.cpp:535
+  //  to expand.
+  if (dyn_cast<VectorType>(Ty)) {
+    return false;
----------------
RKSimon wrote:
> isa<VectorType>(Ty)
Yes :)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71743/new/

https://reviews.llvm.org/D71743