[PATCH] D69770: [APFloat] Add recoverable string parsing errors to APFloat
Craig Topper via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jan 6 00:26:01 PST 2020
craig.topper added inline comments.
================
Comment at: llvm/lib/Support/StringRef.cpp:593
+ if (!ErrOrStatus) {
+ assert("Invalid floating point representation");
+ return true;
----------------
This is an invalid assert.
lib/Support/StringRef.cpp:593:12: warning: implicit conversion turns string literal into bool: 'const char [38]' to 'bool' [-Wstring-conversion]
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D69770/new/
https://reviews.llvm.org/D69770
More information about the llvm-commits
mailing list