[PATCH] D71981: [LLD] [COFF] Don't error out on duplicate absolute symbols with the same value

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Jan 5 23:30:36 PST 2020


MaskRay added inline comments.


================
Comment at: lld/test/COFF/duplicate-absolute-same.s:5
 // RUN: llvm-mc -triple x86_64-windows-msvc -filetype obj -o %t.dupl.obj %t.dupl.s
-// RUN: not lld-link /out:%t.exe %t.obj %t.dupl.obj 2>&1 | FileCheck %s
+// RUN: lld-link /out:%t.exe %t.obj %t.dupl.obj -subsystem:console -entry:entry 2>&1 | FileCheck --allow-empty %s
 
----------------
If there is no diagnostic, use `count 0`. Then, `CHECK-NOT` can be turned into a comment.

Negative diagnostics checks may become stale when the message changes.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71981/new/

https://reviews.llvm.org/D71981





More information about the llvm-commits mailing list