[PATCH] D72226: Short-circuit SCC update for self-referential edge
Brian Gesiak via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sun Jan 5 14:18:18 PST 2020
modocache added a comment.
Yeah, very good questions. When I was writing this patch, I was focused more on getting my specific use case, the one covered by the unit test, to work without hitting an assert. (I also think this is potentially a performance optimization, but I haven't measured in any meaningful way.) But I'm also curious why this occurs, and will look into it a little more. I'd ideally like to get a unit test case that demonstrates the issue without being based on top of D70927 <https://reviews.llvm.org/D70927>, but I wasn't able to in this first iteration of the patch.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D72226/new/
https://reviews.llvm.org/D72226
More information about the llvm-commits
mailing list