[PATCH] D68814: [LV] Allow assume calls in predicated blocks.

[Florian Hahn via Phabricator via llvm-commits]

fhahn updated this revision to Diff 236263.
fhahn added a comment.



In D68814#1804951 <https://reviews.llvm.org/D68814#1804951>, @Ayal wrote:

> Thanks. Perhaps it's better for Legal to declare via getConditionalAssumes() what is being returning, and let LVP decide what to do with them(*), rather than to assume from the start via getAssumesToDrop() that they must all be dropped.
>
> LVP could collect all conditional assumes itself, btw, but it's easier for Legal to do so, and also logical as they deserve special attention in terms of legality.


+1, getAssumesToDrop makes more sense when we improve things in the future. I've updated the name.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68814/new/

https://reviews.llvm.org/D68814

Files:
  llvm/include/llvm/Transforms/Vectorize/LoopVectorizationLegality.h
  llvm/lib/Transforms/Vectorize/LoopVectorizationLegality.cpp
  llvm/lib/Transforms/Vectorize/LoopVectorize.cpp
  llvm/test/Transforms/LoopVectorize/predicate-assume.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D68814.236263.patch
Type: text/x-patch
Size: 11484 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200105/c6980754/attachment.bin>