[PATCH] D65761: Add Windows Control Flow Guard checks (/guard:cf).

Sat Jan 4 10:43:51 PST 2020

hubert.reinterpretcast added a comment.

Is building `check-all` immediately after configuration expected to be clean? I have a build configured to build LLVM with just `clang` and just with the `PowerPC` target, and it seems `check-all` (under such a configuration) does not trigger the building of the library added in this patch; which, in turn, leads to test failures.

  /src/llvm/test/tools/llvm-config/booleans.test:27:24: error: CHECK-SHARED-MODE-NOT: excluded string found in input
  CHECK-SHARED-MODE-NOT: error:
                         ^
  <stdin>:3:14: note: found here
  llvm-config: error: missing: /build/lib/libLLVMCFGuard.a
               ^~~~~~

I have confirmed that the case I mentioned fails with rGd157a9b <https://reviews.llvm.org/rGd157a9bc8ba1085cc4808c6941412322a7fd884e>.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65761/new/

https://reviews.llvm.org/D65761