[PATCH] D72007: [InstCombine] try to pull 'not' of select into compare operands

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri added a comment.

Looks good to me in principle, the case where we get rid of `not` is good,
but i'm not sure about the case where we only manage to sink it into one of the hands.
To me that seems to be the opposite of the current general canonicalizaion we do.
(Do we need Inverter logic, that handles sinking of inversions as far as possible?)

I agree that it is a throughput improvement for final assembly, but not sure about IR.
Is there some bigger pattern (of which this pattern is part of)
which shows why this is the correct IR canonicalization?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72007/new/

https://reviews.llvm.org/D72007