[PATCH] D72194: WIP alternative approach for D68101

[John McCall via Phabricator via llvm-commits]

rjmccall added inline comments.


================
Comment at: llvm/lib/CodeGen/TargetLoweringObjectFileImpl.cpp:608
+      UniqueID = i.first->second;
+    }
   }
----------------
This looks like it should work.  I don't know the MC code design well enough to have an opinion about whether it's better to handle this here or in `getELFSection`.


================
Comment at: llvm/lib/CodeGen/TargetLoweringObjectFileImpl.cpp:623
+  assert (((Section->getEntrySize() == 0) ||
+      (Section->getEntrySize() == getEntrySizeForKind(Kind))));
+
----------------
Is this assertion intentionally allowing `Section` to be non-mergeable?  I feel like this probably should guarantee to return a mergeable section if that's what was requested.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72194/new/

https://reviews.llvm.org/D72194