[PATCH] D72116: [mlir][spirv] Update SPIR-V docs with information about utilities to convert to SPIR-V

[Mahesh Ravishankar via Phabricator via llvm-commits]

mravishankar marked 4 inline comments as done.
mravishankar added inline comments.


================
Comment at: mlir/docs/Dialects/SPIR-V.md:888
+In SPIR-V dialect, builtins are represented using `spv.globalVariable`s, with
+`spv._address_of` used to get a handle to the builtin as an SSA value.  The
+method `mlir::spirv::getBuiltinVariableValue` returns an SSA value, and creates
----------------
antiagainst wrote:
> with `spv._address_of` to get ...
I think "used to get" is better...


================
Comment at: mlir/docs/Dialects/SPIR-V.md:1160
 [GreedyPatternRewriter]: https://github.com/llvm/llvm-project/blob/master/mlir/lib/Transforms/Utils/GreedyPatternRewriteDriver.cpp
+[MlirDialectConversionTypeConversion]: https://github.com/llvm/llvm-project/blob/master/mlir/docs/DialectConversion.md#type-converter
+[MlirDialectConversionRewritePattern]: https://github.com/llvm/llvm-project/blob/master/mlir/docs/DialectConversion.md#conversion-patterns
----------------
antiagainst wrote:
> Use https://mlir.llvm.org/docs/DialectConversion/ for these links
Updated to use relative paths.


================
Comment at: mlir/docs/Dialects/SPIR-V.md:1163
+[MlirDialectConversionSignatureConversion]: https://github.com/llvm/llvm-project/blob/master/mlir/docs/DialectConversion.md#region-signature-conversion
+[MlirIntegerType]: https://github.com/llvm/llvm-project/blob/master/mlir/docs/LangRef.md#integer-type
+[MlirFloatType]: https://github.com/llvm/llvm-project/blob/master/mlir/docs/LangRef.md#floating-point-types
----------------
antiagainst wrote:
> Similarly use https://mlir.llvm.org/docs/LangRef/ here and other markdown files
Updated to use relative paths.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72116/new/

https://reviews.llvm.org/D72116