[PATCH] D69152: [gicombiner] Add GIMatchTree and use it for the code generation

[Daniel Sanders via Phabricator via llvm-commits]

dsanders marked an inline comment as done.
dsanders added inline comments.


================
Comment at: llvm/include/llvm/Target/GlobalISel/Combine.td:106
   (defs root:$d),
-  (match [{ return Helper.matchCombineCopy(${d}); }]),
-  (apply [{ Helper.applyCombineCopy(${d}); }])>;
+  (match (COPY $d, $s):$mi,
+         [{ return Helper.matchCombineCopy(*${mi}); }]),
----------------
volkan wrote:
> Missing `wip_match_opcode` for COPY?
It's not needed here as COPY is the only thing it matches. `wip_match_opcode` is a temporary way of matching one of a set of opcodes until the feature that supports a choice of patterns becomes available.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69152/new/

https://reviews.llvm.org/D69152