[PATCH] D72168: [mlir][Linalg] Add a linalg.reshape op

[River Riddle via Phabricator via llvm-commits]

rriddle added inline comments.


================
Comment at: mlir/include/mlir/IR/StandardTypes.h:12
 
+#include "mlir/IR/AffineExpr.h"
 #include "mlir/IR/Types.h"
----------------
This should be avoided as much as possible. We should avoid adding more includes to headers, especially common ones.


================
Comment at: mlir/include/mlir/IR/StandardTypes.h:590
+/// layout.
+bool isContiguous(MemRefType t);
+
----------------
This looks unused.


================
Comment at: mlir/lib/IR/StandardTypes.cpp:715
+    auto maps = llvm::to_vector<4>(affineMaps);
+    for (auto &m : maps)
+      m = simplifyAffineMap(m);
----------------
Why do these have to be re-simplified? Seems like this could just be done on construction, what is the benefit of doing this here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72168/new/

https://reviews.llvm.org/D72168