[PATCH] D71993: [Transforms][GlobalSRA] huge array causes long compilation time and huge memory usage.
Reid Kleckner via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Jan 3 13:30:28 PST 2020
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm with a small suggestion
================
Comment at: llvm/lib/Transforms/IPO/GlobalOpt.cpp:488
+ std::map<unsigned, GlobalVariable *> NewGlobals;
Module::GlobalListType &Globals = GV->getParent()->getGlobalList();
----------------
I think this Globals variable isn't needed to later, so please sink it to reduce scope.
================
Comment at: llvm/test/Transforms/GlobalOpt/long-compilation-global-sra.ll:1
+; RUN: opt %s --O0 -globalopt -S -o -
+
----------------
Please check for the new global and absence of other globals.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71993/new/
https://reviews.llvm.org/D71993
More information about the llvm-commits
mailing list