[PATCH] D69151: [gicombiner] Import tryCombineIndexedLoadStore()

[Daniel Sanders via llvm-commits]

>  122 |   IndexedLoadStoreMatchInfo MatchData3203412;

The number appended to MatchData looks suspiciously large. It looks a lot like the bug that these two commits fixed:
	0a0813962d6 [globalisel] Attempt to fix ARM bots that emit the correct number in the wrong place
	3a779b7dfd8 [globalisel] Small correction to the fixup in 0a0813962d6. The two ID's are not the same size

Looking at the code, I think there's another one that I missed. In parseDefs(), there's a call to llvm::format() using %d and RuleID (uint64_t) together. Hopefully I'll have a fix shortly.

> On Dec 31, 2019, at 10:12, Adhemerval Zanella via Phabricator <reviews at reviews.llvm.org> wrote:
> 
> zatrazz added a comment.
> 
> Hi,
> 
> I am investigating a recurring regression on arm-linux bots and bisecting the commits on the build [1] that introduced the regression it points to this one. By reverting I can build the stage1 (I am testing now the stage2). I seems to only happen on arm-linux bots, I didn't see it on aarch64-linux ones.
> 
> [1] http://lab.llvm.org:8011/builders/clang-cmake-armv7-selfhost/builds/3251
> 
> 
> Repository:
>  rG LLVM Github Monorepo
> 
> CHANGES SINCE LAST ACTION
>  https://reviews.llvm.org/D69151/new/
> 
> https://reviews.llvm.org/D69151
> 
> 
>