[PATCH] D72173: [mlir] Fix gcc 5.5 build break

River Riddle via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 3 12:11:03 PST 2020


rriddle added inline comments.


================
Comment at: mlir/lib/Dialect/Linalg/Utils/Utils.cpp:101
 template <>
-GenericLoopNestRangeBuilder<loop::ForOp>::GenericLoopNestRangeBuilder(
-    ArrayRef<edsc::ValueHandle *> ivs, ArrayRef<Value> ranges) {
+mlir::edsc::GenericLoopNestRangeBuilder<
+    loop::ForOp>::GenericLoopNestRangeBuilder(ArrayRef<edsc::ValueHandle *> ivs,
----------------
Have you checked to see if this actually fixes the issue? Last time I ran into this, I had to explicitly wrap the def in:

namespace ... {

}

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=56480


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72173/new/

https://reviews.llvm.org/D72173





More information about the llvm-commits mailing list