[PATCH] D72027: [XCOFF][AIX] Support basic relocation type on AIX

[Digger via Phabricator via llvm-commits]

DiggerLin added inline comments.
Herald added a subscriber: wuzish.


================
Comment at: llvm/lib/MC/XCOFFObjectWriter.cpp:350
     // Handle undefined symbol.
     if (ContainingCsect->getCSectType() == XCOFF::XTY_ER) {
       UndefinedCsects.emplace_back(ContainingCsect);
----------------
1. Can We delete code line 350 ~ 354 ?

2. and change  line 333 to
if   ( XCOFF::XTY_ER != MCSec->getCSectType() && nameShouldBeInStringTable(MCSec->getSectionName()))

3. delete line 328 ,329 
    assert(XCOFF::XTY_ER != MCSec->getCSectType() &&
           "An undefined csect should not get registered.");


4. changed the line 336
CsectGroup &Group = getCsectGroup(MCSec);

to 
CsectGroup &Group = (XCOFF::XTY_ER != MCSec->getCSectType() ? getCsectGroup(MCSec):  UndefinedCsects);


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72027/new/

https://reviews.llvm.org/D72027