[PATCH] D70924: [Metadata] Add TBAA struct metadata to `AAMDNode`

[Anton Afanasyev via Phabricator via llvm-commits]

anton-afanasyev marked an inline comment as done.
anton-afanasyev added inline comments.


================
Comment at: llvm/include/llvm/IR/Metadata.h:647
+                     MDNode *S = nullptr, MDNode *N = nullptr)
+      : TBAA(T), TBAAStruct(TS), Scope(S), NoAlias(N) {}
 
----------------
RKSimon wrote:
> I always get worried when constructors with default args get rearranged like this. Maybe change to this:
> ```
> explicit AAMDNodes() = default;
> explicit AAMDNodes(MDNode *T, MDNode *TS, MDNode *S, MDNode *N)
>     : TBAA(T), TBAAStruct(TS), Scope(S), NoAlias(N) {}
> 
> MDNode *TBAA = nullptr; // etc.
> ```
Ok, done.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70924/new/

https://reviews.llvm.org/D70924