[PATCH] D70590: [Examples] Add add_llvm_example_library macro and use it for IR example.

[Florian Hahn via Phabricator via llvm-commits]

fhahn added a comment.

In D70590#1800672 <https://reviews.llvm.org/D70590#1800672>, @compnerd wrote:

> Hmm, I see, yes, that would change the behavior where we would not create the targets for it.  In that case, using `EXCLUDE_FROM_ALL` is fine, but set it as a target property rather than passing global variables like this.  But, even better would be to understand if we even need this.
>
> Really, the `install-distribution` target allows the installed image to contain specific bits, and the `distribution` target lets you build the minimal set.  Having the target being built always when you build *everything* (ALL) is the preferable option.


Thanks for taking a look. The original commit was reverted, so I'll re-commit the original change with the EXCLUDE_FROM_ALL fix. I'll check how to not pass it as global variable.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70590/new/

https://reviews.llvm.org/D70590