[PATCH] D72139: [ARM] Use isFMAFasterThanFMulAndFAdd for scalars as well as MVE vectors

Dave Green via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 3 08:32:20 PST 2020


dmgreen marked an inline comment as done.
dmgreen added inline comments.


================
Comment at: llvm/lib/Target/ARM/ARMISelLowering.cpp:15024
+  case MVT::f16:
+    return Subtarget->hasFullFP16() && !Subtarget->isTargetDarwin() &&
+           Subtarget->useFPVFMx();
----------------
samparker wrote:
> Is there a way this logic can sit in Subtarget to avoid it being a tablegen predicate as well as code here? I'm hopeless with our FP architectures... does FullFP16 infer VFP4?
Yeah, that sounds good. I'll try and move it around.

FullFP16 implies fp-armv8 I'm pretty sure. So at least VFP4.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72139/new/

https://reviews.llvm.org/D72139





More information about the llvm-commits mailing list