[PATCH] D70924: [Metadata] Add TBAA struct metadata to `AAMDNode`

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 3 05:57:54 PST 2020


RKSimon added inline comments.


================
Comment at: llvm/include/llvm/IR/Metadata.h:647
+                     MDNode *S = nullptr, MDNode *N = nullptr)
+      : TBAA(T), TBAAStruct(TS), Scope(S), NoAlias(N) {}
 
----------------
I always get worried when constructors with default args get rearranged like this. Maybe change to this:
```
explicit AAMDNodes() = default;
explicit AAMDNodes(MDNode *T, MDNode *TS, MDNode *S, MDNode *N)
    : TBAA(T), TBAAStruct(TS), Scope(S), NoAlias(N) {}

MDNode *TBAA = nullptr; // etc.
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70924/new/

https://reviews.llvm.org/D70924





More information about the llvm-commits mailing list