[PATCH] D72138: [ARM] Fill in FP16 FMA patterns

[Sam Parker via Phabricator via llvm-commits]

samparker added inline comments.


================
Comment at: llvm/lib/Target/ARM/ARMInstrVFP.td:2215
       Requires<[HasVFP4]>;
+def : Pat<(f16 (fma (fneg HPR:$Sn), HPR:$Sm, (fneg HPR:$Sdin))),
+          (VFNMAH HPR:$Sdin, HPR:$Sn, HPR:$Sm)>,
----------------
Do you think it would be worth doing some canonicalisation somewhere? With two fnegs I'm assuming this pattern is more expensive than the others if not caught.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72138/new/

https://reviews.llvm.org/D72138