[PATCH] D72109: [cmake] Use relative cmake binary dir for processing pass plugins
Alan Baker via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Jan 3 05:38:46 PST 2020
alan-baker marked an inline comment as done.
alan-baker added inline comments.
================
Comment at: llvm/cmake/modules/AddLLVM.cmake:907
+ execute_process(COMMAND ${CMAKE_COMMAND} -E copy_if_different
+ "${CMAKE_CURRENT_BINARY_DIR}/include/llvm/Support/Extension.def.tmp"
+ "${CMAKE_CURRENT_BINARY_DIR}/include/llvm/Support/Extension.def")
----------------
serge-sans-paille wrote:
> Why `CMAKE_CURRENT_BINARY_DIR` and not `LLVM_BINARY_DIR` as in line 903?
That they didn't match was a left over mistake from testing. In my setups they evaluated to the same values. I'll switch all uses to LLVM_BINARY_DIR as Meinersbur suggested.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D72109/new/
https://reviews.llvm.org/D72109
More information about the llvm-commits
mailing list