[PATCH] D71786: RFC: [Support] On Windows, add optional support for rpmalloc

Fri Jan 3 03:42:46 PST 2020

russell.gallop added a comment.

In D71786#1802386 <https://reviews.llvm.org/D71786#1802386>, @aganea wrote:

> In D71786#1801275 <https://reviews.llvm.org/D71786#1801275>, @russell.gallop wrote:
>
> > It fails creating a library
>
>
> Could you please run `ninja -v`, and ensure `LLVMSupport.lib` appears first on the linker cmd-line? (before other libs).

The link.exe command line is:

  >C:\PROGRA~2\MIB055~1\2019\PROFES~1\VC\Tools\MSVC\1424~1.283\bin\Hostx64\x64\link.exe /nologo tools\remarks-shlib\CMakeFiles\Remarks.dir\libremarks.cpp.obj tools\remarks-shlib\CMakeFiles\Remarks.dir\__\__\resources\windows_version_resource.rc.res /out:bin\Remarks.dll /implib:lib\Remarks.lib /pdb:bin\Remarks.pdb /dll /version:0.0 /machine:x64 /INCREMENTAL:NO /DEF:<path>/llvm-project/build_vs/tools/remarks-shlib/Remarks.def lib\LLVMRemarks.lib lib\LLVMBitstreamReader.lib lib\LLVMSupport.lib psapi.lib shell32.lib ole32.lib uuid.lib advapi32.lib delayimp.lib -delayload:shell32.dll -delayload:ole32.dll lib\LLVMDemangle.lib kernel32.lib user32.lib gdi32.lib winspool.lib shell32.lib ole32.lib oleaut32.lib uuid.lib comdlg32.lib advapi32.lib /MANIFEST /MANIFESTFILE:bin\Remarks.dll.manifest

> Now add `/INCLUDE:malloc` to the link cmd-line and re-run it, see if that fixes the issue. That will force the `malloc` symbol to be processed first, and consequently to consider `LLVMSupport.lib` before any `#pragma comment(linker, "/defaultlib:libucrt.lib")` directive is encountered.

With /INCLUDE:malloc the above link line completes successfully.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71786/new/

https://reviews.llvm.org/D71786