[llvm] 91cbcbd - [test][llvm-dwarfdump] Add missing checks for table dumping

James Henderson via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 3 03:18:03 PST 2020


Author: James Henderson
Date: 2020-01-03T11:06:31Z
New Revision: 91cbcbd9e501a37ce08f5a4d4060a90248c700d6

URL: https://github.com/llvm/llvm-project/commit/91cbcbd9e501a37ce08f5a4d4060a90248c700d6
DIFF: https://github.com/llvm/llvm-project/commit/91cbcbd9e501a37ce08f5a4d4060a90248c700d6.diff

LOG: [test][llvm-dwarfdump] Add missing checks for table dumping

Some of the tables in debug_line_malformed.s were not being checked in
the NONFATAL checks in debug_line_invalid.test (only the warnings coming
from them were being checked). This made the test harder to follow.
Additionally, a later change will change the way the errors are handled
such that more of the line table will be printed. That will require
checks for these tables (or something equivalent) so that the difference
in behaviour can be observed. This patch adds checks for the three
tables that were missing checks.

Reviewed By: MaskRay

Differential Revision: https://reviews.llvm.org/D71753

Added: 
    

Modified: 
    llvm/test/tools/llvm-dwarfdump/X86/debug_line_invalid.test

Removed: 
    


################################################################################
diff  --git a/llvm/test/tools/llvm-dwarfdump/X86/debug_line_invalid.test b/llvm/test/tools/llvm-dwarfdump/X86/debug_line_invalid.test
index ebd9e9d8e8a4..a24751186e26 100644
--- a/llvm/test/tools/llvm-dwarfdump/X86/debug_line_invalid.test
+++ b/llvm/test/tools/llvm-dwarfdump/X86/debug_line_invalid.test
@@ -98,8 +98,22 @@
 ## Case 8: Very short prologue length for V5 (ends during parameters).
 # NONFATAL: debug_line[0x00000183]
 # NONFATAL-NEXT: Line table prologue
+# NONFATAL-NOT:  Address
 
-## TODO: Add checks here for remaining tables.
+## Case 9: V5 prologue ends during file table.
+# NONFATAL: debug_line[0x000001be]
+# NONFATAL-NEXT: Line table prologue
+# NONFATAL-NOT:  Address
+
+## Case 10: V5 prologue ends during directory table.
+# NONFATAL: debug_line[0x000001f9]
+# NONFATAL-NEXT: Line table prologue
+# NONFATAL-NOT:  Address
+
+## Case 11: V5 invalid MD5 hash form.
+# NONFATAL: debug_line[0x00000234]
+# NONFATAL-NEXT: Line table prologue
+# NONFATAL-NOT:  Address
 
 # NONFATAL: debug_line[0x00000271]
 # NONFATAL-NOT: debug_line[{{.*}}]


        


More information about the llvm-commits mailing list