[PATCH] D72094: [mlir][linalg] Lower linalg to affine loops

[Alex Zinenko via Phabricator via llvm-commits]

ftynse added inline comments.
Herald added subscribers: lucyrfox, mgester.


================
Comment at: mlir/include/mlir/Dialect/Linalg/Utils/Utils.h:68
 
+// Helper template class for building loop.for and affine.loop nests from
+// ranges.
----------------
MLIR uses `///` for class documentation


================
Comment at: mlir/lib/Dialect/Linalg/Utils/Utils.cpp:113
+  for (const Value range : ranges) {
+    RangeOp rangeOp = cast<RangeOp>(range.getDefiningOp());
+    lbs.push_back(ValueHandle(rangeOp.min()));
----------------
Does something guarantee that there is a defining op?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72094/new/

https://reviews.llvm.org/D72094