[PATCH] D71711: [COFF] Make the autogenerated .weak.<name>.default symbols static

Thu Jan 2 21:59:32 PST 2020

mstorsjo added a comment.

In D71711#1802223 <https://reviews.llvm.org/D71711#1802223>, @rnk wrote:

> I guess if the absolute symbol change is enough to unblock you, I'd leave this alone for now. The gnu behavior seems error prone and difficult to implement.

Yeah, it seems hard to do sensibly - but it'd be necessary (in the generic case, not for the present weak tls init function case) if the linker errors out on combinations of absolute zero and regular. So strictly, it'd be necessary for clang+ld.bfd, for a wider use of weak, and also for lld if we change that aspect there.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71711/new/

https://reviews.llvm.org/D71711