[PATCH] D71693: [NFC][PowerPC] Add a function tryAndWithMask

Amy Kwan via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 2 19:58:22 PST 2020


amyk added a comment.

One minor comment from me. I also agree with what has been stated previously (to try to simplify `tryAndWithMask()`).



================
Comment at: llvm/lib/Target/PowerPC/PPCISelDAGToDAG.cpp:4349
 
+bool PPCDAGToDAGISel::tryAndWithMask(SDNode *N) {
+  if (N->getOpcode() != ISD::AND)
----------------
If we are to add a new function, I think it is beneficial to add some doxygen comments for the function.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71693/new/

https://reviews.llvm.org/D71693





More information about the llvm-commits mailing list