[PATCH] D72067: [PowerPC] Delete PPCSubtarget::isDarwin and isDarwinABI

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCSubtarget.cpp:147
-  if (isDarwin())
-    HasLazyResolverStubs = true;
-
----------------
sfertile wrote:
> I believe the  member variable `HasLazyResolverStubs` should be dead with the Darwin removal.  Likewise for `PPCSubtarget::hasLazyResolverStub`.
It looks like `PPCSubtarget::hasLazyResolverStub` is the only member variable that is dead now. I'll delete related code.


================
Comment at: llvm/test/CodeGen/PowerPC/2008-10-31-PPCF128Libcalls.ll:16
-	%2 = load ppc_fp128, ppc_fp128* @b, align 16		; <ppc_fp128> [#uses=1]
-	%3 = call ppc_fp128 @"\01_sinl$LDBL128"(ppc_fp128 %2) nounwind readonly		; <ppc_fp128> [#uses=1]
-	store ppc_fp128 %3, ppc_fp128* @b, align 16
----------------
jsji wrote:
> Why we are removing whole testcase? Can we just use `llvm.sinl.ppcf128` instead?
D50988 did

```
-target triple = "powerpc-apple-darwin10.0"
+target triple = "powerpc-unknown-linux-gnu"
```

`*$LDBL128` is used exclusively by Darwin. We have more appropriate tests for ELF ppc_fp128 in ppc_fp128*.ll ppc_f128* and various other files.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72067/new/

https://reviews.llvm.org/D72067