[PATCH] D72111: Move inline-asm setup/cleanup directives outside of the "#APP" "#NO_APP" comment.

James Y Knight via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 2 14:09:57 PST 2020


jyknight created this revision.
jyknight added a reviewer: Nicola.
Herald added subscribers: llvm-commits, atanasyan, jrtc27, hiraditya, arichardson, sdardis.
Herald added a project: LLVM.

After this change, only the user-specified assembly goes inside the
"APP" comment markers, not the mode-change directives. This only
affects MIPS at the moment, but we may soon start doing a similar
mode-change on X86 as well.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D72111

Files:
  llvm/lib/CodeGen/AsmPrinter/AsmPrinterInlineAsm.cpp
  llvm/lib/Target/Mips/MipsAsmPrinter.cpp
  llvm/test/CodeGen/Mips/inlineasm-assembler-directives.ll
  llvm/test/CodeGen/Mips/inlineasm-constraint-reg.ll
  llvm/test/CodeGen/Mips/inlineasm-constraint-reg64.ll
  llvm/test/CodeGen/Mips/shrink-wrapping.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D72111.235947.patch
Type: text/x-patch
Size: 9587 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200102/adb17188/attachment.bin>


More information about the llvm-commits mailing list