[PATCH] D72094: [mlir][linalg] Lower linalg to affine loops

[River Riddle via Phabricator via llvm-commits]

rriddle added inline comments.


================
Comment at: mlir/include/mlir/Dialect/Linalg/Utils/Utils.h:12
 
+#include "mlir/Dialect/AffineOps/AffineOps.h"
 #include "mlir/Dialect/Linalg/IR/LinalgOps.h"
----------------
Why is this header necessary?


================
Comment at: mlir/lib/Dialect/Linalg/Utils/Utils.cpp:26
 #include "mlir/Pass/Pass.h"
+#include "mlir/Support/LLVM.h"
 #include "mlir/Support/STLExtras.h"
----------------
Is this really necessary here?


================
Comment at: mlir/lib/Dialect/Linalg/Utils/Utils.cpp:114
+  SmallVector<int64_t, 4> steps;
+  for (const auto range : ranges) {
+    auto rangeOp = cast<RangeOp>(range.getDefiningOp());
----------------
const auto -> Value


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72094/new/

https://reviews.llvm.org/D72094