[PATCH] D72022: [mlir][Linalg] Extend generic ops to allow tensors

Mahesh Ravishankar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 2 10:08:18 PST 2020


mravishankar added a comment.
Herald added a subscriber: arpith-jacob.

Without commenting on the specifics of the change itself, was wondering what advantage there is to allow generic ops to take tensor values as well. Until now lowering from Linalg to (say) GPU Dialect was fairly straight-forward cause Linalg operated on memref types. I am not sure what would happen if the generic op with tensors would be lowered to GPU dialect (presumably should be an error), and lowering it correctly would need some buffer allocation to kick in. So it seems like this is adding complexity. Could you please provide some context behind the need for this change?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72022/new/

https://reviews.llvm.org/D72022





More information about the llvm-commits mailing list