[PATCH] D71947: [MLIR][spirv] Allow specifying availability on enum attribute cases

Lei Zhang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 2 10:08:19 PST 2020


antiagainst added a comment.

In D71947#1801532 <https://reviews.llvm.org/D71947#1801532>, @mravishankar wrote:

> Would still prefer the version/capability related methods into a separate file.


You mean in the SPIR-V dialect or the TableGen backend? For the former I'm open to suggestions given that they will stay as what is implemented here for the foreseeable future (minus minor changes maybe) so having a clean library structure makes sense. For the latter, I won't worry that much given that eventually they will be moved to a proper place in core.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71947/new/

https://reviews.llvm.org/D71947





More information about the llvm-commits mailing list