[llvm] 87fb204 - [SelectionDAG] Simplify SelectionDAGBuilder::visitInlineAsm

Fangrui Song via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 2 09:44:31 PST 2020


Author: Fangrui Song
Date: 2020-01-02T09:44:23-08:00
New Revision: 87fb204e8f049a0f9d8a6db069c8730ddd800305

URL: https://github.com/llvm/llvm-project/commit/87fb204e8f049a0f9d8a6db069c8730ddd800305
DIFF: https://github.com/llvm/llvm-project/commit/87fb204e8f049a0f9d8a6db069c8730ddd800305.diff

LOG: [SelectionDAG] Simplify SelectionDAGBuilder::visitInlineAsm

Added: 
    

Modified: 
    llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp b/llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp
index b78b8e93435e..ffc8c3c19a32 100644
--- a/llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp
+++ b/llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp
@@ -8181,7 +8181,6 @@ void SelectionDAGBuilder::visitInlineAsm(ImmutableCallSite CS) {
         AsmNodeOperands.push_back(DAG.getTargetConstant(OpFlags, getCurSDLoc(),
                                                         MVT::i32));
         AsmNodeOperands.push_back(OpInfo.CallOperand);
-        break;
       } else {
         // Otherwise, this outputs to a register (directly for C_Register /
         // C_RegisterClass, and a target-defined fashion for
@@ -8318,8 +8317,7 @@ void SelectionDAGBuilder::visitInlineAsm(ImmutableCallSite CS) {
       }
 
       assert((OpInfo.ConstraintType == TargetLowering::C_RegisterClass ||
-              OpInfo.ConstraintType == TargetLowering::C_Register ||
-              OpInfo.ConstraintType == TargetLowering::C_Immediate) &&
+              OpInfo.ConstraintType == TargetLowering::C_Register) &&
              "Unknown constraint type!");
 
       // TODO: Support this.


        


More information about the llvm-commits mailing list