[PATCH] D71904: [mlir] GPU: introduce utilities for promotion to workgroup memory

Nicolas Vasilache via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 2 09:40:08 PST 2020


nicolasvasilache added inline comments.


================
Comment at: mlir/lib/Dialect/GPU/Transforms/MemoryPromotion.cpp:73
+/// are dominated by any operation this emitted.
+static void emitLoopBounds(InsertCopiesLoopBounds &bounds, OpBuilder &builder,
+                           Location loc, MemRefType type) {
----------------
To tie the previous suggestions together:
1. use EDSC `MemRefView` (feel free to rename), to capture all lbs/ubs/steps
2. add your dummy dims
3. emit loops, they are captured automatically
4. apply `mapToProcessorIds` on the k-innermost loops


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71904/new/

https://reviews.llvm.org/D71904





More information about the llvm-commits mailing list