[PATCH] D71916: High-Level Code-Review Documentation Update

Hubert Tong via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 2 09:10:44 PST 2020


hubert.reinterpretcast marked an inline comment as done.
hubert.reinterpretcast added inline comments.


================
Comment at: llvm/docs/CodeReview.rst:99
+the author can make all of the changes at once. If a patch will require
+multiple steps prior to approval (e.g., splitting, refactoring, posting data
+from specific performance tests), please explain as many of these up front as
----------------
jhenderson wrote:
> e.g., -> e.g.
> 
> Same goes for all other instances of this pattern. Alternatively, consider using "for example,"
The use with the comma is consistent with the use and description in the MLA Handbook, 6th ed. My understanding is that the comma is customary in North American usage.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71916/new/

https://reviews.llvm.org/D71916





More information about the llvm-commits mailing list