[PATCH] D71957: [llvm-size] print a blank line between archieve members when using sysv format

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 2 08:52:04 PST 2020


jhenderson accepted this revision.
jhenderson added a comment.

LGTM. Please make sure @Jim is happy with this too.



================
Comment at: llvm/tools/llvm-size/llvm-size.cpp:449
     outs() << format(fmt.str().c_str(), static_cast<const char *>("Total"),
-                     total);
+                     total) << "\n";
   } else {
----------------
Jim wrote:
> Put "<< "\n"" in the new line look better.
> 
> ```
> outs() << format... 
>        << "\n";
> ```
I think this is correct, but to be sure if you haven't already, run git-clang-format on the modified part to verify your formatting choices match the official style (see https://llvm.org/docs/GettingStarted.html#sending-patches).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71957/new/

https://reviews.llvm.org/D71957





More information about the llvm-commits mailing list