[PATCH] D61446: Generalize the pass registration mechanism used by Polly to any third-party tool

Nico Weber via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 2 08:04:48 PST 2020


thakis added inline comments.


================
Comment at: llvm/test/lit.site.cfg.py.in:6
+def cmake_bool(val):
+    return val.lower() in (1, "on", "yes", "true", "y",)
+
----------------
FYI, this is a now-discouraged pattern. It's better to use llvm_canonicalize_cmake_booleans in the cmake file instead. See https://reviews.llvm.org/D56912 for an example.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61446/new/

https://reviews.llvm.org/D61446





More information about the llvm-commits mailing list