[PATCH] D67495: [RISCV] Collect Statistics on Compressed Instructions

Luís Marques via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 2 02:25:43 PST 2020


luismarques accepted this revision.
luismarques added a comment.
This revision is now accepted and ready to land.

LGTM. My only concern was if it made sense to use the same statistic to count in both places, and if we could end up double counting the instructions emitted (now, or in a future LLVM version). After a quick look I didn't really see other targets using the same approach, but I also can't think of a way where this ends up actually being problematic.

(Nipick: maybe put a comment in the statistic reminding people that the linker may further compress some of the instructions we emitted uncompressed?)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67495/new/

https://reviews.llvm.org/D67495





More information about the llvm-commits mailing list