[PATCH] D72079: [mlir][Linalg] NFC - Rename ViewTraits -> StructuredOpTraits

[Nicolas Vasilache via Phabricator via llvm-commits]

nicolasvasilache created this revision.
nicolasvasilache added a reviewer: ftynse.
Herald added subscribers: llvm-commits, antiagainst, shauheen, burmako, jpienaar, rriddle, mehdi_amini.
Herald added a project: LLVM.
ftynse accepted this revision.
This revision is now accepted and ready to land.

This is part of an ongoing cleanup and uniformization work.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D72079

Files:
  mlir/include/mlir/Dialect/Linalg/IR/LinalgLibraryOps.td
  mlir/include/mlir/Dialect/Linalg/IR/LinalgStructuredOps.td
  mlir/include/mlir/Dialect/Linalg/IR/LinalgTraits.h


Index: mlir/include/mlir/Dialect/Linalg/IR/LinalgTraits.h
===================================================================
--- mlir/include/mlir/Dialect/Linalg/IR/LinalgTraits.h
+++ mlir/include/mlir/Dialect/Linalg/IR/LinalgTraits.h
@@ -55,7 +55,8 @@
 ///   class DotOp : public Op<DotOp, OpTrait::ViewTrait> {
 ///
 template <typename ConcreteType>
-class ViewTraits : public OpTrait::TraitBase<ConcreteType, ViewTraits> {
+class StructuredOpTraits
+    : public OpTrait::TraitBase<ConcreteType, StructuredOpTraits> {
 private:
   /// Return the number of input views. For internal use only.
   unsigned nInputs() {
Index: mlir/include/mlir/Dialect/Linalg/IR/LinalgStructuredOps.td
===================================================================
--- mlir/include/mlir/Dialect/Linalg/IR/LinalgStructuredOps.td
+++ mlir/include/mlir/Dialect/Linalg/IR/LinalgStructuredOps.td
@@ -29,7 +29,7 @@
 class NOutputs<int args_out> :
   NativeOpTrait<"linalg::NOutputs<" # !cast<string>(args_out) # ">::Impl"> {}
 
-def ViewTraits : NativeOpTrait<"linalg::ViewTraits">;
+def StructuredOpTraits : NativeOpTrait<"linalg::StructuredOpTraits">;
 
 // The linalg 'LinalgStructuredInterface' provides access to the 'LinalgOp'
 // interface.
@@ -147,7 +147,7 @@
 // depending on the specific Linalg op.
 class LinalgStructuredBase_Op<string mnemonic, list<OpTrait> props>
   : Op<Linalg_Dialect, mnemonic,
-       !listconcat(props, [ViewTraits, LinalgStructuredInterface])> {
+       !listconcat(props, [StructuredOpTraits, LinalgStructuredInterface])> {
   let parser = [{ return parseLinalgStructuredOp(parser, result); }];
   let printer = [{ printLinalgStructuredOp(p, *this); }];
 }
Index: mlir/include/mlir/Dialect/Linalg/IR/LinalgLibraryOps.td
===================================================================
--- mlir/include/mlir/Dialect/Linalg/IR/LinalgLibraryOps.td
+++ mlir/include/mlir/Dialect/Linalg/IR/LinalgLibraryOps.td
@@ -29,7 +29,7 @@
 class NOutputs<int args_out> :
   NativeOpTrait<"linalg::NOutputs<" # !cast<string>(args_out) # ">::Impl"> {}
 
-def ViewTraits : NativeOpTrait<"linalg::ViewTraits">;
+def StructuredOpTraits : NativeOpTrait<"linalg::StructuredOpTraits">;
 
 // The linalg 'LinalgLibraryInterface' provides access to the 'LinalgOp'
 // interface.
@@ -147,7 +147,7 @@
 // depending on the specific Linalg op.
 class LinalgLibraryBase_Op<string mnemonic, list<OpTrait> props>
   : Op<Linalg_Dialect, mnemonic,
-       !listconcat(props, [ViewTraits, LinalgLibraryInterface])> {
+       !listconcat(props, [StructuredOpTraits, LinalgLibraryInterface])> {
   let parser = [{ return parseLinalgLibraryOp(parser, result); }];
   let printer = [{ printLinalgLibraryOp(p, *this); }];
 }


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D72079.235861.patch
Type: text/x-patch
Size: 2709 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200102/5d1b8a16/attachment.bin>