[PATCH] D71896: [llvm-readobj][llvm-readelf][test] - Add a few more dynamic section tests.

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

What are the formatting issues you are referring to in your description?

It might be worth updating the description to enumerate the new test cases (i.e. 32-bit and proc/os-specific values).



================
Comment at: llvm/test/tools/llvm-objdump/elf-dynamic-section.test:1
-# RUN: yaml2obj %s > %t
-# RUN: llvm-objdump -p %t | FileCheck %s
+# RUN: yaml2obj --docnum=1 %s > %t1
+# RUN: llvm-objdump -p %t1 | FileCheck %s --strict-whitespace --match-full-lines --check-prefix=ELF64
----------------
Maybe -o, since you're changing this line.


================
Comment at: llvm/test/tools/llvm-objdump/elf-dynamic-section.test:195
        Value: 0x3
-     - Tag:   0x1234abcd
+## Show behaviour for unknown values in special and un-marked ranges.
+## An arbitrary unknown value outside of the special ranges.
----------------
un-marked -> unmarked

Same in other places.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71896/new/

https://reviews.llvm.org/D71896