[PATCH] D71835: [llvm-readobj] - Remove an excessive helper for printing dynamic tags.
James Henderson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jan 2 04:06:43 PST 2020
jhenderson added a comment.
> I am not sure we want to follow GNU here. Even if we do, it should be separate patch probably. The new output looks better and closer to GNU anyways, and the code is a bit simpler.
FWIW, I'm not sure I see a benefit from diverging from GNU here. The only thing I can think of is the lack of '0x' potentially making the value confusing, but the value is actually listed in the first column anyway, so that point isn't exactly an issue.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71835/new/
https://reviews.llvm.org/D71835
More information about the llvm-commits
mailing list