[PATCH] D72069: [NFC] Add explicit instantiation to releaseNode

Lorenzo Casalino via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 2 03:57:24 PST 2020


DoktorC accepted this revision.
DoktorC added a comment.
This revision is now accepted and ready to land.

As pointed out by @teemperor, it would be better to fix the error as soon as possible.

I see your point @fhahn, @steven.zhang e and @lkail, eventhough I'm not totally convinced
about correct inlining by the compiler (but these are words of a newbie, and, unfortunately, I
do not have the possibilty to personally check if inlining is performed).

Since the build passed, we may let land this patch to fix any trouble caused, and carefully plan
to do a proper follow up with function argument, instead of template argument.

This LGTM! Thank you all!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72069/new/

https://reviews.llvm.org/D72069





More information about the llvm-commits mailing list