[PATCH] D72069: [NFC] Add explicit instantiation to releaseNode

[Qiu Chaofan via Phabricator via llvm-commits]

qiucf marked 2 inline comments as done.
qiucf added inline comments.


================
Comment at: llvm/lib/CodeGen/MachineScheduler.cpp:2091
 
-template <bool InPQueue>
-void SchedBoundary::releaseNode(SUnit *SU, unsigned ReadyCycle, unsigned Idx) {
+void SchedBoundary::releaseNodeImpl(SUnit *SU, unsigned ReadyCycle,
+                                    unsigned Idx, bool InPQueue) {
----------------
lkail wrote:
> Can template explicit instantiation help? By adding
> ```
> template void SchedBoundary::releaseNode<true>(SUnit *SU, unsigned ReadyCycle,                                                                                                                 
>                                                unsigned Idx);                                                                                                                                  
> template void SchedBoundary::releaseNode<false>(SUnit *SU, unsigned ReadyCycle,                                                                                                                
>                                                 unsigned Idx);
> ```
> before this line.
This helps in both Clang and GCC. Thanks.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72069/new/

https://reviews.llvm.org/D72069