[PATCH] D71885: [PowerPC] replace rlwinm operand 1 with src rlwinm operand 1
qshanz via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jan 1 22:00:22 PST 2020
steven.zhang added inline comments.
================
Comment at: llvm/lib/Target/PowerPC/PPCMIPeephole.cpp:963
+ if (MRI->use_nodbg_empty(FoldingReg) &&
+ (SrcMI->getOpcode() == PPC::RLWINM ||
+ SrcMI->getOpcode() == PPC::RLWINM8)) {
----------------
steven.zhang wrote:
> You don't need to check the opcode any more and it will fix the missing case of
> ```
> RLWINM
> RLWINMo -->
>
> ANDIo
> ```
Can we use the check of SrcMI->hasImplicitDef() instead of enumerating the opcode to be more flexible ?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71885/new/
https://reviews.llvm.org/D71885
More information about the llvm-commits
mailing list