[PATCH] D72065: [mlir] NFC: Fix broken links in docs

Kazuaki Ishizaki via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 1 21:47:44 PST 2020


kiszk added inline comments.


================
Comment at: mlir/docs/OpDefinitions.md:1206
 [TableGenBackend]: https://llvm.org/docs/TableGen/BackEnds.html#introduction
-[OpBase]: https://github.com/tensorflow/mlir/blob/master/include/mlir/IR/OpBase.td
-[OpDefinitionsGen]: https://github.com/tensorflow/mlir/blob/master/tools/mlir-tblgen/OpDefinitionsGen.cpp
-[EnumsGen]: https://github.com/tensorflow/mlir/blob/master/tools/mlir-tblgen/EnumsGen.cpp
-[StringAttr]: https://github.com/tensorflow/mlir/blob/master/g3doc/LangRef.md#string-attribute
-[IntegerAttr]: https://github.com/tensorflow/mlir/blob/master/g3doc/LangRef.md#integer-attribute
+[OpBase]: https://github.com/llvm/llvm-project/blob/master/mlir/include/mlir/IR/OpBase.td
+[OpDefinitionsGen]: https://github.com/llvm/llvm-project/blob/master/mlir/tools/mlir-tblgen/OpDefinitionsGen.cpp
----------------
rriddle wrote:
> rriddle wrote:
> > Can we use relative paths for these instead? Same with the fixes in the other files.
> (I mean for the ones where it makes sense, i.e. StringAttr, etc.)
Sure, I will address this


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72065/new/

https://reviews.llvm.org/D72065





More information about the llvm-commits mailing list