[PATCH] D72062: [mlir][spirv] Fix shader ABI attribute prefix and add verification

[Lei Zhang via Phabricator via llvm-commits]

antiagainst created this revision.
antiagainst added reviewers: mravishankar, denis13.
Herald added subscribers: llvm-commits, csigg, nicolasvasilache, shauheen, burmako, jpienaar, rriddle, mehdi_amini.
Herald added a project: LLVM.

This commit fixes shader ABI attributes to use `spv.` as the prefix
so that they match the dialect's namespace. This enables use to
add verification hooks in the SPIR-V dialect to verify them.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D72062

Files:
  mlir/include/mlir/Dialect/SPIRV/SPIRVDialect.h
  mlir/lib/Dialect/SPIRV/SPIRVDialect.cpp
  mlir/lib/Dialect/SPIRV/TargetAndABI.cpp
  mlir/test/Conversion/GPUToSPIRV/load-store.mlir
  mlir/test/Conversion/GPUToSPIRV/simple.mlir
  mlir/test/Dialect/SPIRV/Transforms/abi-load-store.mlir
  mlir/test/Dialect/SPIRV/Transforms/abi-simple.mlir
  mlir/test/Dialect/SPIRV/target-and-abi.mlir

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D72062.235815.patch
Type: text/x-patch
Size: 19200 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200102/6d881a98/attachment-0001.bin>