[PATCH] D72054: [mlir][spirv] NFC: Move shader ABI attributes to a new file

Lei Zhang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 1 19:42:36 PST 2020


antiagainst added a comment.

In D72054#1800648 <https://reviews.llvm.org/D72054#1800648>, @mravishankar wrote:

> Just wondering why the refactoring?


This is preparing for adding verification hooks for these attributes. The verification hooks are defined in the SPIR-V dialect class so we need to have a cleaner story for dependency. (I'll have a follow-up CL, which will make this clearer.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72054/new/

https://reviews.llvm.org/D72054





More information about the llvm-commits mailing list