[PATCH] D71617: [WIP][NFC][Attributor] noalias attribute deduction fixme

[pankaj gode via Phabricator via llvm-commits]

pgode updated this revision to Diff 235776.
pgode added a comment.

Thanks @jdoerfert for detailed explanation and listing the corrections.

Modifications in this patch are:

- In checkForAllUses, iterating over all uses instead of earlier iterating over reachable ones only. Using AnyUnreachable (similar to AnyDead) to track AA dependencies. Here I just set this flag if UserI and getCtxI() is not reachable and I don't skip this but continue with checking for Pred. I am also recording dependencies as suggested by @jdoerfert .
- Modified the UsePred, to check for nocapture using AANoCapture and checking reachability for UserI and getCtxI.

With this patch 3 tests are modified.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71617/new/

https://reviews.llvm.org/D71617

Files:
  llvm/include/llvm/Transforms/IPO/Attributor.h
  llvm/lib/Transforms/IPO/Attributor.cpp
  llvm/test/Transforms/Attributor/IPConstantProp/pthreads.ll
  llvm/test/Transforms/Attributor/callbacks.ll
  llvm/test/Transforms/Attributor/noalias.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D71617.235776.patch
Type: text/x-patch
Size: 10689 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200101/36c16faa/attachment.bin>