[PATCH] D72048: [InstCombine] Preserve nuw on sub of geps (PR44419)

[Nikita Popov via Phabricator via llvm-commits]

nikic added a comment.

Fun fact: If you change https://github.com/llvm/llvm-project/blob/773667b8c20d35c18334f8c7663df8ceacfdd2e5/llvm/include/llvm/Analysis/Utils/Local.h#L92 to not emit a useless `add 0, %x` you get a regression in https://github.com/llvm/llvm-project/blob/773667b8c20d35c18334f8c7663df8ceacfdd2e5/llvm/test/Transforms/InstCombine/icmp.ll#L513-L524, because IRBuilder instructions get inserted into the InstCombine worklist in the wrong order :(


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72048/new/

https://reviews.llvm.org/D72048